-
-
Notifications
You must be signed in to change notification settings - Fork 36k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(donate):add donation modal and certification message #37822
Conversation
2f3b5a1
to
0b57f47
Compare
This pr will display a donation message on a certificate if the username of the certificate matches the username of the signed in user. The message will disappear for the session if user clicks on the message link and get redirected to donate page. Additionally a modal will be displayed after the last challenge of a block has been submitted. if either of the donation requests has been shown during a session, the other one will not be shown. Please let me know if the logic is in place so I could proceed with tests. |
@ojeytonwilliams, could you take a quick look? |
Please provide detailed context about when this modal is to be shown for QA in the OP. |
@raisedadead, the modal will be shown after the last challenge on a block has been completed. an easy way to test it would be the data viz certificates. the donation should pop up after the last challenge has been completed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The UX is great, but I'm not sure if it's always behaving exactly as it's supposed to and there's potentially an issue for slow connections:
client/src/templates/Challenges/redux/current-challenge-saga.js
Outdated
Show resolved
Hide resolved
… opening donation modal.
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Tries to fetch the user if they appear not to be signed in and logs the pageview with ga.
c70002f
to
1566045
Compare
@ojeytonwilliams could you take another look? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I noticed I'd named an action badly, so I added some suggestions to fix that. I didn't change donationRequested
to preventDonationRequests
, because I was worried I'd miss one. I can add that as a separate commit.
As far as functionality goes, everything looks good. The following is just nitpicking about names:
client/src/templates/Challenges/redux/current-challenge-saga.test.js
Outdated
Show resolved
Hide resolved
client/src/templates/Challenges/redux/current-challenge-saga.test.js
Outdated
Show resolved
Hide resolved
client/src/templates/Challenges/redux/current-challenge-saga.test.js
Outdated
Show resolved
Hide resolved
client/src/templates/Challenges/redux/current-challenge-saga.test.js
Outdated
Show resolved
Hide resolved
client/src/templates/Challenges/redux/current-challenge-saga.test.js
Outdated
Show resolved
Hide resolved
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
…est.js Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
…est.js Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
…est.js Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
…est.js Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
…est.js Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Eslint's complaining about the constructor:
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
…mp#37822) Co-Authored-By: Oliver Eyton-Williams <ojeytonwilliams@gmail.com>
Update index.md
)master
branch of freeCodeCamp.Closes #XXXXX